Skip to content

Always cache union and intersection relations #46528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Always cache union and intersection relations #46528

wants to merge 4 commits into from

Conversation

ahejlsberg
Copy link
Member

Experiment for now.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 26, 2021
@ahejlsberg
Copy link
Member Author

@typescript-bot perf test faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 26, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 6499302. You can monitor the build here.

Update: The results are in!

@ahejlsberg ahejlsberg mentioned this pull request Oct 26, 2021
Merged
@typescript-bot
Copy link
Collaborator

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..46528

Metric main 46528 Delta Best Worst
Angular - node (v14.15.1, x64)
Memory used 330,354k (± 0.01%) 330,462k (± 0.00%) +108k (+ 0.03%) 330,427k 330,486k
Parse Time 1.95s (± 0.64%) 1.94s (± 0.30%) -0.01s (- 0.31%) 1.93s 1.95s
Bind Time 0.86s (± 0.69%) 0.86s (± 0.55%) +0.00s (+ 0.47%) 0.85s 0.87s
Check Time 5.33s (± 0.43%) 5.33s (± 0.35%) +0.00s (+ 0.06%) 5.30s 5.38s
Emit Time 6.13s (± 0.50%) 6.13s (± 0.36%) -0.00s (- 0.03%) 6.08s 6.17s
Total Time 14.26s (± 0.26%) 14.26s (± 0.20%) -0.00s (- 0.01%) 14.18s 14.34s
Compiler-Unions - node (v14.15.1, x64)
Memory used 192,567k (± 0.49%) 192,703k (± 0.47%) +135k (+ 0.07%) 190,377k 193,608k
Parse Time 0.81s (± 0.69%) 0.81s (± 0.62%) -0.00s (- 0.37%) 0.80s 0.82s
Bind Time 0.55s (± 0.40%) 0.55s (± 0.90%) +0.00s (+ 0.73%) 0.55s 0.57s
Check Time 7.53s (± 0.44%) 7.53s (± 0.63%) -0.00s (- 0.03%) 7.41s 7.64s
Emit Time 2.44s (± 0.71%) 2.44s (± 1.18%) -0.00s (- 0.08%) 2.38s 2.52s
Total Time 11.34s (± 0.42%) 11.33s (± 0.58%) -0.00s (- 0.04%) 11.21s 11.47s
Monaco - node (v14.15.1, x64)
Memory used 324,010k (± 0.01%) 324,039k (± 0.00%) +29k (+ 0.01%) 324,002k 324,078k
Parse Time 1.51s (± 0.62%) 1.50s (± 0.56%) -0.01s (- 0.46%) 1.49s 1.52s
Bind Time 0.75s (± 0.48%) 0.76s (± 0.85%) +0.00s (+ 0.53%) 0.75s 0.77s
Check Time 5.30s (± 0.42%) 5.30s (± 0.54%) -0.00s (- 0.04%) 5.26s 5.37s
Emit Time 3.20s (± 0.53%) 3.20s (± 0.62%) -0.00s (- 0.09%) 3.15s 3.24s
Total Time 10.76s (± 0.31%) 10.75s (± 0.34%) -0.01s (- 0.09%) 10.71s 10.84s
TFS - node (v14.15.1, x64)
Memory used 288,365k (± 0.01%) 288,487k (± 0.00%) +122k (+ 0.04%) 288,465k 288,517k
Parse Time 1.23s (± 0.70%) 1.23s (± 0.66%) +0.00s (+ 0.08%) 1.22s 1.25s
Bind Time 0.73s (± 0.76%) 0.73s (± 0.96%) -0.00s (- 0.14%) 0.72s 0.75s
Check Time 4.90s (± 0.53%) 4.89s (± 0.16%) -0.00s (- 0.10%) 4.87s 4.91s
Emit Time 3.48s (± 0.69%) 3.46s (± 0.33%) -0.01s (- 0.40%) 3.44s 3.49s
Total Time 10.34s (± 0.35%) 10.32s (± 0.19%) -0.02s (- 0.21%) 10.27s 10.36s
material-ui - node (v14.15.1, x64)
Memory used 447,290k (± 0.08%) 449,166k (± 0.01%) +1,876k (+ 0.42%) 449,117k 449,243k
Parse Time 1.82s (± 0.49%) 1.82s (± 0.37%) -0.01s (- 0.49%) 1.80s 1.83s
Bind Time 0.68s (± 0.54%) 0.68s (± 0.49%) +0.00s (+ 0.59%) 0.67s 0.69s
Check Time 13.09s (± 0.97%) 13.03s (± 0.41%) -0.07s (- 0.50%) 12.93s 13.18s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.59s (± 0.84%) 15.52s (± 0.35%) -0.07s (- 0.46%) 15.43s 15.69s
xstate - node (v14.15.1, x64)
Memory used 533,836k (± 0.01%) 534,113k (± 0.01%) +277k (+ 0.05%) 534,043k 534,191k
Parse Time 2.55s (± 0.54%) 2.56s (± 0.35%) +0.01s (+ 0.47%) 2.54s 2.59s
Bind Time 1.15s (± 0.82%) 1.15s (± 0.77%) -0.00s (- 0.26%) 1.14s 1.17s
Check Time 1.55s (± 0.54%) 1.55s (± 0.54%) +0.00s (+ 0.26%) 1.53s 1.57s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.32s (± 0.36%) 5.34s (± 0.34%) +0.01s (+ 0.24%) 5.31s 5.39s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory10 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 46528 10
Baseline main 10

Developer Information:

Download Benchmark

@ahejlsberg ahejlsberg closed this Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@ahejlsberg ahejlsberg

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahejlsberg @typescript-bot